[CBO-1777] Update googlemaps-services for Ruby 2.7 support#3888
Merged
Joseph Haig (jrmhaig) merged 1 commit intomasterfrom Apr 15, 2021
Merged
[CBO-1777] Update googlemaps-services for Ruby 2.7 support#3888Joseph Haig (jrmhaig) merged 1 commit intomasterfrom
Joseph Haig (jrmhaig) merged 1 commit intomasterfrom
Conversation
Contributor
|
I notice this gem is not very popular. from a quick view i wonder whether this one is worth a look as seesm more popular but even older |
Contributor
Author
|
Joel Sugarman (@jsugarman) I am currently looking at the Update: It looks as though our use case is out of the scope of |
This is using this branch on Github: https://github.com/jrmhaig/googlemaps-services/tree/update_http One it has been merged and a new version released then that should be used instead (see amrfaissal/googlemaps-services#13)
Joseph Haig (jrmhaig)
force-pushed
the
jh/update_googlemaps-services
branch
from
67ea0d9 to
4058844
Compare
Joel Sugarman (jsugarman)
approved these changes
Apr 15, 2021
Contributor
Joel Sugarman (jsugarman)
left a comment
Joel Sugarman (jsugarman)
left a comment
There was a problem hiding this comment.
👍 as an interim measure this looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Update the
googlemaps-servicesgem to use this branch: https://github.com/jrmhaig/googlemaps-services/tree/update_httpTicket
Mileage calculation intermittent failures
Why
The
googlemaps-servicesgem has a dependency on thehttpgem pinned to a version that does not support Ruby 2.7. This results in intermittent failures. A PR has been submitted togooglemaps-services(amrfaissal/googlemaps-services#13) but it has not yet been merged.Once the PR has been merged and a new version released then we need to update
Gemfileto use the released version again.